refactor(web-ui): tighten theme color governance - #1254
Merged
limityan merged 2 commits intoJun 18, 2026
Conversation
limityan
force-pushed
the
yanzhn/theme-color-remaining-scope
branch
from
June 18, 2026 03:48
f6f423a to
234bdfb
Compare
Consolidate remaining app UI raw colors, token-equivalent literals, and fallback defaults across theme surfaces. Lower the color governance baseline to the new audited counts and document the retained near-color boundaries.
Tokenize DiffEditor diff color layers and merge safe near-identical visual colors. Update theme color governance baseline after reducing near pairs from 16 to 5.
limityan
force-pushed
the
yanzhn/theme-color-remaining-scope
branch
from
June 18, 2026 04:11
234bdfb to
c851a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gcwing/main(d8f2d2e2) so ordinary app/component raw colors, token-equivalent literals, near color pairs, and CSS var governance errors remain at zero.Refs #1197
Audit impact
gcwing/main)var(--token, fallback)occurrencesRetained domains
The remaining color literals are deliberately scoped to explicit owner domains rather than ordinary app UI: theme presets/runtime, token contracts, boundary fallback, Mermaid, Monaco/editor, Prism syntax, terminal ANSI, language identity, and the UI exception registry. The exception/boundary counts rise because formerly scattered fixed identity colors and isolated-surface fallbacks are now classified in registries with owners, not because new free-floating app colors were added.
Risk review
UI_EXCEPTION_ACCENTS,BUILTIN_LANGUAGE_ACCENTS, orSHARED_PRISM_COLOR_SCHEME; mapped usages are typed records or direct static property access.d8f2d2e2corrected three drift risks: reStructuredText identity remains#141414, ContextCompressionCard keeps its previous fixed dark surface through private RGB channels, and DiffEditor keeps its GitHub-style added/deleted RGB channels instead of inheriting global git tokens.Validation
git fetch gcwing maingit rebase gcwing/maingit rev-list --left-right --count gcwing/main...HEAD->0 2git merge-base --is-ancestor gcwing/main HEADpnpm run theme:color-auditgit diff --checkpnpm run lint:web(passes with 4 existing warnings outside this diff)pnpm run type-check:webpnpm --dir src/web-ui run test:run(213 files, 1178 tests)pnpm run build:web(passes; existing Vite chunk/dynamic import warnings remain)